doc: move building nodejs into its own document #5634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| ### Unix / Macintosh | ||
| See [BUILDING.md](BUILDING.md) for further instructions on how to build nodejs. |
There was a problem hiding this comment.
Nit: for further instructions -> for instructions
Nit: nodejs -> Node.js
Tentative nit: how to build Node.js -> how to build Node.js from source
|
LGTM |
|
Tentative nit: Maybe file name should be |
|
@Trott re |
|
LGTM |
1 similar comment
|
LGTM |
This makes README.md easier to consume and likely less confusing for people that get it as part of a binary download. PR-URL: nodejs#5634 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: James M Snell <jasnell@gmail.com>
jbergstroem
force-pushed
the
doc/separate-build-instructions
branch
from
7aa09f1
to
5d21496
Compare
|
All green. Merging. |
evanlucas
pushed a commit
that referenced
this pull request
Mar 14, 2016
This makes README.md easier to consume and likely less confusing for people that get it as part of a binary download. PR-URL: #5634 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
rvagg
pushed a commit
that referenced
this pull request
Mar 16, 2016
This makes README.md easier to consume and likely less confusing for people that get it as part of a binary download. PR-URL: #5634 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 17, 2016
This makes README.md easier to consume and likely less confusing for people that get it as part of a binary download. PR-URL: #5634 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 21, 2016
This makes README.md easier to consume and likely less confusing for people that get it as part of a binary download. PR-URL: #5634 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 21, 2016
This makes README.md easier to consume and likely less confusing for people that get it as part of a binary download. PR-URL: #5634 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make -j8 test(UNIX) orvcbuild test nosign(Windows) pass withthis change (including linting)?
test (or a benchmark) included?
existing APIs, or introduces new ones)?
Affected core subsystem(s)
Documentation
Description of change
This makes the main README easier to consume and likely less confusing for people that get it as part of a binary download.
Refs #5612 (comment).
/cc @Trott